Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How does Milvus install by Helm can support dynamic configuration changes when I changed config user.yaml in config map? #94

Open
anhnch30820 opened this issue May 31, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@anhnch30820
Copy link

I see document in K8s
A container using a ConfigMap as a subPath volume mount will not receive ConfigMap updates.
And helm use subPath:

- name: milvus-config
  mountPath: /milvus/configs/user.yaml
  subPath: user.yaml
  readOnly: true
@haorenfsa
Copy link
Collaborator

@anhnch30820 For now it's supported in milvus-operator , we'll migrate it to helm soon.

https://github.com/zilliztech/milvus-operator/releases/tag/v0.9.15

@haorenfsa haorenfsa self-assigned this Jun 3, 2024
@haorenfsa haorenfsa added the enhancement New feature or request label Jun 3, 2024
@anhnch30820
Copy link
Author

thank you

@anhnch30820
Copy link
Author

Hi @haorenfsa, Does helm support dynamic for now?

@haorenfsa
Copy link
Collaborator

@anhnch30820 No, I haven't got time to manage that. l list the changes needed below., so that you may change your deployment for dynamic config. Or if you're interested, you could also make a patch for our chart.

Each deploy should be added with:

  • an starting script /milvus/tools/run.sh and related volumeMounts.
  • an initContainer to copy binaries needed for run.sh
  • change the volumeMount's path, and remove subpath field.
apiVersion: apps/v1
kind: Deployment
metadata:
  name: milvus-indexnode
spec:
  template:
    spec:
      containers:
      - args:
        - /milvus/tools/run.sh
        - milvus
        - run
        - indexnode
        name: indexnode
        volumeMounts:
        - mountPath: /milvus/configs/operator
          name: milvus-config
          readOnly: true
        - mountPath: /milvus/tools
          name: tools
      initContainers:
      - args:
        - /init.sh
        command:
        - /bin/sh
        image: milvusdb/milvus-tools:v1.0.0
        resources: {}
        volumeMounts:
        - mountPath: /milvus/configs/operator
          name: milvus-config
          readOnly: true
        - mountPath: /milvus/tools
          name: tools
      volumes:
      - configMap:
          name: milvus
        name: milvus-config
      - emptyDir: {}
        name: tools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants