Knowhere cannot be compiled using clang-19

[alexanderguzhva]

The particular version of clang-19 is 20240903024120+0c641568515a.

The error is the following:

grpc/1.50.1: 
grpc/1.50.1: ERROR: Package '32da9aa5ad2d83d4c3396a84a985ed6f618ca9e9' build failed
grpc/1.50.1: WARN: Build folder /home/ubuntu/.conan/data/grpc/1.50.1/_/_/build/32da9aa5ad2d83d4c3396a84a985ed6f618ca9e9/build/Release

In file included from /home/ubuntu/.conan/data/grpc/1.50.1/_/_/build/32da9aa5ad2d83d4c3396a84a985ed6f618ca9e9/src/src/core/ext/filters/channel_idle/channel_idle_filter.cc:47:
In file included from /home/ubuntu/.conan/data/grpc/1.50.1/_/_/build/32da9aa5ad2d83d4c3396a84a985ed6f618ca9e9/src/src/core/lib/promise/try_seq.h:26:
/home/ubuntu/.conan/data/grpc/1.50.1/_/_/build/32da9aa5ad2d83d4c3396a84a985ed6f618ca9e9/src/src/core/lib/promise/detail/basic_seq.h:499:38: error: a template argument list is expected after a name prefixed by the template keyword [-Wmissing-template-arg-list-after-template-kw]
  499 |                     Traits::template CallSeqFactory(f_, *cur_, std::move(arg)));
      |                                      ^

I do not have such a problem with clang-17 or clang-18

Do WE REALLY need GRPC is knowhere?

[liliu-z]

@PwzXxm Do you know why we have GRPC in knowhere? I don't think we need that

[PwzXxm]

@PwzXxm Do you know why we have GRPC in knowhere? I don't think we need that

One possible reason is that opentelemetry-cpp depends on gRPC. It could be excluded if we built knowhere standalone, maybe?

[liliu-z]

@PwzXxm Do you know why we have GRPC in knowhere? I don't think we need that

One possible reason is that opentelemetry-cpp depends on gRPC. It could be excluded if we built knowhere standalone, maybe?

To my understanding, we didn't use GRPC in our usage of opentelemetry-cpp. Is there any compilation flag to avoid including that in?

[alexanderguzhva]

@PwzXxm Do you know why we have GRPC in knowhere? I don't think we need that

One possible reason is that opentelemetry-cpp depends on gRPC. It could be excluded if we built knowhere standalone, maybe?

This wont' fix the problem with milvus, because milvus relies on gRPC as well. gRPC needs to be upgraded, I suppose?

[PwzXxm]

Alex's right. cc @yellow-shine

[yellow-shine]

Based on the Conan dependency graph for the Milvus project, we can observe the following relationships for the grpc/1.50.1@milvus/dev package:

Required by:

1. opentelemetry-cpp/1.8.1.1@milvus/2.4
2. google-cloud-cpp/2.5.0@milvus/2.4
3. milvus (via conanfile.py)

below is how i got this:

cd milvus/internal/core

conan info .

...
grpc/1.50.1@milvus/dev
    ID: b41117b4d616a9b0a268083d337e09492232483b
    BuildID: None
    Context: host
    Remote: None
    URL: https://github.com/conan-io/conan-center-index
    Homepage: https://github.com/grpc/grpc
    License: Apache-2.0
    Description: Google's RPC (remote procedure call) library and framework.
    Topics: rpc
    Provides: grpc
    Recipe: No remote
    Binary: Missing
    Binary remote: None
    Creation date: 2024-08-09 10:03:17 UTC
    Required by:
        opentelemetry-cpp/1.8.1.1@milvus/2.4
        google-cloud-cpp/2.5.0@milvus/2.4
        conanfile.py
    Requires:
        abseil/20230125.3
        protobuf/3.21.4
        c-ares/1.32.1
        openssl/3.1.2
        re2/20230301
        zlib/1.2.13
...

[alexanderguzhva]

@yellow-shine Do I get it correct that it is not very straightforward to upgrade grpc / libraries versions for milvus? Technically, clang-19 is not a big deal

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

[alexanderguzhva]

/reopen
this is still a valid problem

[sre-ci-robot]

@alexanderguzhva: Reopened this issue.

In response to this:

/reopen
this is still a valid problem

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.