Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help needed understanding a test failure in jupyter_client + pypy #1581

Open
mattip opened this issue Aug 6, 2021 · 1 comment
Open

Help needed understanding a test failure in jupyter_client + pypy #1581

mattip opened this issue Aug 6, 2021 · 1 comment

Comments

@mattip
Copy link
Contributor

mattip commented Aug 6, 2021

It seems there is a problem somewhere releasing a resource so that the jupyter kernel can die. This manifests itself both in a PR to ipykernel and a PR to jupyter_client. I wonder if it has something to do with pyzmq?

If someone who understands the different layers could take a look that would be greatly appreciated.

@minrk
Copy link
Member

minrk commented Aug 9, 2021

I poked around, and my strong suspicion is that most if not all of these are related to the difference in garbage collection. this one in particular is exactly that - a direct test of the consequences of del which shouldn't be assumed. I'd argue that test should be updated to test less - just verify that msg['tracker'] is present at all, since the rest is really testing internal pyzmq machinery already covered in this repo.

I was able to infrequently reproduce the uuid-in-stdout failure, and that's another race - there's a time.sleep(1) which is a race, and I guess startup is slower on pypy. That can be fixed with a more direct wait-for-stdout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants