Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problem: no browser test #2

Open
somdoron opened this issue Sep 4, 2019 · 4 comments
Open

problem: no browser test #2

somdoron opened this issue Sep 4, 2019 · 4 comments

Comments

@somdoron
Copy link
Member

somdoron commented Sep 4, 2019

I cannot find a way to test from browser as I also need to test from nodejs for the server.
Ideas are welcome

@cryptoquick
Copy link
Collaborator

I'd actually be interested in offering to adapt a small test app I made using this library for use as an example app and as an integration test. I built it as an experiment for developing larger parts of the app, and I've been so happy with ZeroMQ, I think we'll be moving forward with the larger project. The experiment will likely go unused in its current form, so I'd be happy to donate it to this project.

I was thinking something along these lines:

For the NodeJS API:
https://github.com/ProDataLab-Community/Component-Editor/blob/19da651d86488b9871255f641b03fe72126e93bf/src/api/index.ts

This is the view:

https://github.com/ProDataLab-Community/Component-Editor/blob/19da651d86488b9871255f641b03fe72126e93bf/src/web/views/Chat.tsx

And here are the serialization functions:

https://github.com/ProDataLab-Community/Component-Editor/blob/19da651d86488b9871255f641b03fe72126e93bf/src/lib/interfaces.ts

NOTE: I'm still having trouble with the serialization functions using MessagePack, I think there's a small encoding difference, but I'm not 100% sure what it is just yet. There is a working version of this app I'm temporarily hosting here:

http://104.131.40.55/chat

All the React, Express, and Cypress stuff would be heavy, but we'd just have to be careful to be sure to set NODE_ENV to production so that devDependencies don't get pushed to NPM, of course.

@somdoron
Copy link
Member Author

We can put it under example directory with its own package.json and can run the example as part of the CI?

That way we wouldn't need to add React or Express to the current package.json

@cryptoquick
Copy link
Collaborator

That's a good point, and a very good idea!

@sphaero
Copy link

sphaero commented Jan 22, 2021

Please let's also have a simple javascript example as well without any react/typescript/bloat. Just something directly runable by a browser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants