Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cancel button for each of the ongoing docset downloads #1027

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add cancel button for each of the ongoing docset downloads #1027

wants to merge 3 commits into from

Conversation

nishanthkarthik
Copy link
Contributor

Preview

cancelbuttonspecific

The Cancel button cancels the current download by emitting a cancelButtonClicked signal. This signal is emitted by overriding QStyledItemDelegate::editorEvent and checking if the QMouseEvent coordinates fall inside the cancel button bounds

@nishanthkarthik
Copy link
Contributor Author

This fixes #712

@trollixx
Copy link
Member

trollixx commented Nov 7, 2018

Thanks for the contribution!

After a quick test I've noticed that the Cancel button stays visible during installation stage, but does not do anything.

There are two options here: a) hide the button, b) make cancellation work for installation. The second requires more work, and should be submitted as a separate PR first.

trollixx
trollixx previously requested changes Nov 7, 2018
View reviewed changes
Copy link
Member

@trollixx trollixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional comments.

src/libs/ui/docsetsdialog.cpp Outdated Show resolved Hide resolved
src/libs/ui/docsetsdialog.cpp Outdated Show resolved Hide resolved
src/libs/ui/progressitemdelegate.cpp Show resolved Hide resolved
src/libs/ui/progressitemdelegate.cpp Outdated Show resolved Hide resolved
src/libs/ui/progressitemdelegate.cpp Outdated Show resolved Hide resolved
src/libs/ui/progressitemdelegate.h Show resolved Hide resolved
@trollixx trollixx dismissed their stale review February 7, 2020 05:25

Will rebase/merge on top of master.

@trollixx
Copy link
Member

trollixx commented Feb 7, 2020

It's been a while, and sorry for ignoring this for so long. I believe this should go in, and can be polished later. The base branch has changed a lot, and some files do not even exist any more. Rebasing is pretty much impossible, but copied changes seem to work as expected. Let me know if you want to update the PR yourself, otherwise I'll push my version (with attribution) in a couple of days.

@trollixx
Copy link
Member

trollixx commented Feb 7, 2020

I've force-pushed the original changes without the insanity of merge commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trollixx trollixx trollixx left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nishanthkarthik @trollixx