New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global `ENCODING_KEYS` set #290

Open

TomNicholas opened this issue Nov 8, 2024 · 0 comments

Labels

good first issue

Member

TomNicholas commented Nov 8, 2024 •

edited

Loading

I just noticed this exact set also occurs here

VirtualiZarr/virtualizarr/writers/icechunk.py

Line 148 in 4ae7a19

_encoding_keys = {"_FillValue", "missing_value", "scale_factor", "add_offset"}

Perhaps we should make this a semi-private global variable defined in a common location? Perhaps move it to virtualizarr/backend.py?

Originally posted by @TomNicholas in #265 (comment)

The text was updated successfully, but these errors were encountered:

TomNicholas mentioned this issue

dmrpp root and nested group parsing fix #265

Merged

4 tasks

TomNicholas added the good first issue label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment