Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prettier peer dependency lint warning resolved #1006

Closed
wants to merge 1 commit into from
Closed

Prettier peer dependency lint warning resolved #1006

wants to merge 1 commit into from

Conversation

njmulsqb
Copy link
Contributor

Signed-off-by: njmulsqb [email protected]

Hi @psiinon,

I have resolved the prettier peer dependency (lint warning)

There are other warnings as well, if this PR gets merged I'll look how can I resolve rest of the warnings, so it partially resolves #608

@thc202
Copy link
Member

thc202 commented Sep 16, 2021

Where are you seeing that warning?

@njmulsqb
Copy link
Contributor Author

Where are you seeing that warning?

I am seeing this when building zap hud.
image

@thc202
Copy link
Member

thc202 commented Sep 16, 2021

Which commit? The CI build is not showing that:
https://github.com/zaproxy/zap-hud/runs/3618514889#step:5:46

@njmulsqb
Copy link
Contributor Author

Which commit? The CI build is not showing that:
https://github.com/zaproxy/zap-hud/runs/3618514889#step:5:46

No idea, I just took the fresh clone of zap-hud and it was appearing at my end

@njmulsqb njmulsqb closed this Sep 17, 2021
@njmulsqb njmulsqb deleted the feature-fixlint branch September 17, 2021 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix lint warnings
2 participants
@njmulsqb @thc202