Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lint warnings #608

Open
9 tasks
psiinon opened this issue Sep 26, 2019 · 2 comments
Open
9 tasks

Fix lint warnings #608

psiinon opened this issue Sep 26, 2019 · 2 comments
Assignees
@VitikaSoni
Labels
maintenance Code or build changes that make the project easier to maintain

Comments

@psiinon
Copy link
Member

psiinon commented Sep 26, 2019 •
edited
Loading

The following rules were set to "warn" so that we could focus on more important issues, but these should all be fixed as well:

  • no-negated-condition
  • no-unused-vars
  • prefer-destructuring
  • unicorn/no-for-loop
  • unicorn/prefer-includes
  • unicorn/prefer-string-slice
  • unicorn/filename-case
  • unicorn/prefer-query-selector
  • Unsafe assignment to innerHTML no-unsanitized/property - see FIXME in in display.js

The overrides are defined in https://github.com/zaproxy/zap-hud/blob/develop/package.json#L54-L63 (the lines may change in time)
@psiinon psiinon added the maintenance Code or build changes that make the project easier to maintain label Sep 26, 2019
@psiinon psiinon mentioned this issue Oct 10, 2019
Merged
3 tasks
This was referenced Sep 16, 2021
Closed
Merged
@VitikaSoni
Copy link
Contributor

@psiinon I want to fix some of these, could you please assign me?

@psiinon
Copy link
Member Author

psiinon commented Jan 30, 2023

Assigned 😁

@VitikaSoni VitikaSoni mentioned this issue Jan 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VitikaSoni VitikaSoni

Labels
maintenance Code or build changes that make the project easier to maintain
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prettier peer dependency lint warning resolved njmulsqb/zap-hud
2 participants
@psiinon @VitikaSoni