-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support building with Java 17 #1062
Comments
Java 17 requires Gradle 7.3. I just started looking into upgrading ZAP builds to Gradle 7.3.3 yesterday 🙂. |
@LIttleAncientForestKami ciuld you update your cloned copy and give this a try again? |
It fails with same error:
The npm plugin might need to be updated. |
@kingthorin that is one fast tempo, oh Oakenshield!
I ran build scan for details, here you go: https://scans.gradle.com/s/yxpjba3ajjsku/ |
Thanks! |
There "seems" to be something more to this. The dependencyUpdates task doesn't seem to suggest anything that I would think is related, it claims the npm plugin is up-to-date: $ ./gradlew dependencyUpdates
Starting a Gradle Daemon (subsequent builds will be faster)
> Task :buildSrc:jar
:jar: No valid plugin descriptors were found in META-INF/gradle-plugins
> Task :dependencyUpdates
------------------------------------------------------------
: Project Dependency Updates (report to plain text file)
------------------------------------------------------------
The following dependencies are using the latest milestone version:
- org.hamcrest:hamcrest-all:1.3
- org.ysb33r.nodejs.npm:org.ysb33r.nodejs.npm.gradle.plugin:0.12.1
- org.zaproxy.add-on:org.zaproxy.add-on.gradle.plugin:0.8.0
- org.zaproxy.crowdin:org.zaproxy.crowdin.gradle.plugin:0.2.1
The following dependencies have later milestone versions:
- com.diffplug.spotless:com.diffplug.spotless.gradle.plugin [5.17.1 -> 6.2.0]
- com.github.ben-manes.versions:com.github.ben-manes.versions.gradle.plugin [0.39.0 -> 0.41.0]
- io.github.bonigarcia:selenium-jupiter [3.4.0 -> 4.0.1]
https://bonigarcia.dev/selenium-jupiter
- org.junit.jupiter:junit-jupiter-api [5.8.1 -> 5.8.2]
https://junit.org/junit5/
- org.junit.jupiter:junit-jupiter-engine [5.8.1 -> 5.8.2]
https://junit.org/junit5/
- org.junit.jupiter:junit-jupiter-params [5.8.1 -> 5.8.2]
https://junit.org/junit5/
- org.mockito:mockito-all [1.10.19 -> 2.0.2-beta]
http://www.mockito.org
Gradle release-candidate updates:
- Gradle: [7.3.3 -> 7.4-rc-1]
Generated report file C:\Rick\ZAP_DEV\git\zap-hud\build\dependencyUpdates\report.txt
BUILD SUCCESSFUL in 3m 20s
10 actionable tasks: 10 executed
|
I didn't check if a newer version of the plugin was available just assumed it would need a newer one (since this version is broken). |
Hi there folks!
First of all, wanted to thank you soundly. Really, this is impressive, both the idea and the execution. Thank you a lot for your work.
Kudos to the entire team. <confetti, fanfares, horns blaring, roaring applause>
Again, I'm really grateful for your work done on this project guys.
The issue I found has a workaround - namely, lower Java to 11. I tried running freshly coded repo, from master, on XUbuntu with Java 17, via Gradle wrapper, via installed Gradle and failed on both accounts - with different error messages. Succeeded when I lowered Java to 11 and
Java 17, Gradle 7.2 (via wrapper) - fails on npm dependencies
Gradle 6.2, installed, not via wrapper
But lowering Java to 11 solved the problem and launched the tool (did NOT attempt via wrapper with Java 11 so this may be a different issue).
Again, thank you for your work guys. Hope this helps.
The text was updated successfully, but these errors were encountered: