Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZAP-HUD doesn't work with WebGoat 8.2.2 #1044

Open
davewichers opened this issue Nov 8, 2021 · 2 comments
Open

ZAP-HUD doesn't work with WebGoat 8.2.2 #1044

davewichers opened this issue Nov 8, 2021 · 2 comments

Comments

@davewichers
Copy link

This is related to issue #585 I believe.

When you launch ZAP w/FireFox and HUD you see lots of automatic AJAX requests to:

http://localhost:8080/WebGoat/service/lessoninfo.mvc
http://localhost:8080/WebGoat/service/lessonmenu.mvc.*

So, to make intercepts work properly, you have to exclude these two URLs. When you do, you still seem them all the time, presumably because HUD forces HTTPS (which seems weird to me).

So, to REALLY get ZAP to stop logging these URLs, you have to also add:

https://localhost:8080/WebGoat/service/lessoninfo.mvc
https://localhost:8080/WebGoat/service/lessonmenu.mvc.*

Which is NOT intuitive at all. And after you do this, other things break. Specifically:

When you add: https://localhost:8080/WebGoat/service/lessoninfo.mvc - You stop seeing the lesson stages for each lesson. You either see blank, or only stage 1, even if there are like 5, 6, 10 stages to a lessons.
When you add: https://localhost:8080/WebGoat/service/lessonmenu.mvc - You see a spinner forever where the lesson menu should be.

As ZAP and WebGoat are BOTH from OWASP, seems like we should figure out how to make them work well together well with the HUD.

First off, WHY does it force HTTPS? Doesn't seem like it should need to do that. If we stopped doing that, both these issues might just 'go away'.

@davewichers davewichers changed the title ZAP-Hud doesn't work with WebGoat 8.2.2 ZAP-HUD doesn't work with WebGoat 8.2.2 Nov 8, 2021
@psiinon
Copy link
Member

psiinon commented Nov 9, 2021

As per https://groups.google.com/g/zaproxy-users/c/QZrQU-KGkWk/m/lThons3LAwAJ (and the later comment) the HUD has to upgrade a site to HTTPS otherwise it cant work. And if the site doesnt handle HTTPS then ZAP handles that on its behalf.

It sounds like ZAP is not upgrading the http AJAX calls. Do you see redirects in the responses?
Is WebGoat not following the redirects?
If you can explain how it works then we can look at fixing it.
Although right now we dont actually have anyone focussing on HUD development :(

@thc202
Copy link
Member

thc202 commented Nov 9, 2021

The problem is that once the session URLs are excluded they will no longer be downgraded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants