Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of github.com/pkg/errors #2488

Closed
Tracked by #2433
AlexanderYastrebov opened this issue Jul 31, 2023 · 3 comments
Closed
Tracked by #2433

Remove use of github.com/pkg/errors #2488

AlexanderYastrebov opened this issue Jul 31, 2023 · 3 comments

Comments

@AlexanderYastrebov
Copy link
Member

AlexanderYastrebov commented Jul 31, 2023

See pkg/errors#245

We can probably replace it by https://pkg.go.dev/errors#Join introduced in 1.20

@AlexanderYastrebov
Copy link
Member Author

After #2492 we still have it as indirect

$ go mod why -m github.com/pkg/errors
# github.com/pkg/errors
github.com/zalando/skipper/tracing/tracers/jaeger
github.com/uber/jaeger-client-go/config
github.com/pkg/errors

Related to #2153 and #2104

@AlexanderYastrebov
Copy link
Member Author

If jaeger dependency is removed then

$ go mod why -m github.com/pkg/errors
# github.com/pkg/errors
github.com/zalando/skipper/net/redistest
github.com/testcontainers/testcontainers-go
github.com/docker/docker/api/types/registry
github.com/pkg/errors

@AlexanderYastrebov
Copy link
Member Author

There are other dependencies, namely OPA, using github.com/pkg/errors:

$ go mod graph | grep github.com/pkg/errors
github.com/zalando/skipper github.com/pkg/[email protected]
github.com/containerd/[email protected] github.com/pkg/[email protected]
github.com/dgraph-io/badger/[email protected] github.com/pkg/[email protected]
github.com/dgraph-io/[email protected] github.com/pkg/[email protected]
github.com/open-policy-agent/[email protected] github.com/pkg/[email protected]
github.com/open-policy-agent/[email protected] github.com/pkg/[email protected]
github.com/opencontainers/[email protected] github.com/pkg/[email protected]
github.com/testcontainers/[email protected] github.com/pkg/[email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant