-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 10Play #31892
base: master
Are you sure you want to change the base?
Fix 10Play #31892
Conversation
As far as I can tell this is now essentially every episode of every show.
oh, btw - I wasn't sure how to write tests that require authentication. I've just set the parameter to use netrc; I feel like that's not ideal, but as I mentioned in the PR, there's almost no videos that don't require authentication. The only one I could find was football match highlights, but they don't stick around for very long. |
... Thanks for your efforts 😄 ; back in Sep of last year, I took part in the discussion of related #31236, where the current maintainer (@dirkf) posted a yet unmerged patch to the You might also want to mark your PR as, hopefully, "fixing" open issues #28641, #31236 (main one) and #31302 ... Regards 😃 |
... Also, I downloaded locally the File "tenplay.py", line 91
f'https://10play.com.au/api/shows/{show}/episodes/{season}', f"{show}/{season}",
^
SyntaxError: invalid syntax ... f-strings were first introduced in py3.6 😉 ... |
* back-port PR * improve geo-block detection
With apologies to @gormster, I've updated this PR with changes including the latest update from yt-dlp/yt-dlp/pull/10928. Since I only get geo-blocking I've also been able to improve that area over the yt-dlp code. But now the actual extraction needs to be tested by users in the AU region, please. The proper way to do this is to check out this branch and run the program from the A user who is able/happy to patch the changed tenplay.py (this only works for certain installation types and is generally not recommended) can check out the updated In either case please comment out the lines like this 'skip': 'Only available in Australia', in the test cases, run the tests and post the results. |
Please follow the guide below
x
into all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
This PR does two things for the 10Play extractor:
After searching the PRs it seems like @aarubui created a patch for the first issue in #28728 but withdrew it for unspecified reasons. So here's another working version, and this time it does playlists, too!
Edit: