Skip to content
This repository has been archived by the owner on Sep 2, 2022. It is now read-only.

compiler: literal handling #57

Open
tsatke opened this issue Sep 22, 2020 · 0 comments
Open

compiler: literal handling #57

tsatke opened this issue Sep 22, 2020 · 0 comments
Assignees

Comments

@tsatke
Copy link
Contributor

tsatke commented Sep 22, 2020

See #55

For the AST, I'd like two new interfaces and three new structs.

type (
    ColumnReferenceExpression interface { ... }
    LiteralExpression         interface { ... }

    ConstantLiteral struct {}                  // implements LiteralExpression
    ConstantLiteralOrColumnReference struct {} // implements both LiteralExpression and ColumnReferenceExpression
    ColumnReference struct {}                  // implements ColumnReferenceExpression
)

I expect that this facilitates handling in the engine a lot.
Whoever implements this; feel free to change the names suggested above. However, the names should be somewhat consistent with what we already have.

@tsatke tsatke mentioned this issue Sep 22, 2020
5 tasks
@tsatke tsatke self-assigned this Oct 3, 2020
tsatke added a commit that referenced this issue Oct 28, 2020
tsatke added a commit that referenced this issue Oct 30, 2020
Mainly fix some warnings. Also skipped a not working test and created a follow-up ticket.
tsatke added a commit that referenced this issue Oct 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant