Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong default column for interstellar attenuation file in module_generator #397

Open
lmauviard opened this issue Sep 3, 2024 · 0 comments · May be fixed by #402
Open

Wrong default column for interstellar attenuation file in module_generator #397

lmauviard opened this issue Sep 3, 2024 · 0 comments · May be fixed by #402
Assignees
@lmauviard

Comments

@lmauviard
Copy link
Collaborator

Module generator uses column 1 (indexed from 0) as default to extract interstellar attenuation from file. But the usual table for interstellar absorption interstellar_phot_frac.txt has this value in column 2.
This is not much, but should we change this since it can be quite misleading and easy to make a mistake there ?
@lmauviard lmauviard self-assigned this Sep 3, 2024
@lmauviard lmauviard linked a pull request Nov 7, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lmauviard lmauviard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Default attenuation column corrected in module_generator lmauviard/xpsi
1 participant
@lmauviard