Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signal plots produce wrong figures if including channel 0 and using logarithmic y-scale #371

Open
thjsal opened this issue Mar 5, 2024 · 0 comments
Assignees
Labels
bug Something isn't working hackweek2024 Issues to be fixed during the 2024 Hack Week

Comments

@thjsal
Copy link
Contributor

thjsal commented Mar 5, 2024

For example, if including channel number 0 in to the analysis, one can get a residual plot like this:
residuals_original.pdf
when it really should look like this (note: in this example there are no counts below channel ~20):
residuals_fixed.pdf

To fix the problem one can replace lines like self._ax_resid.set_ylim([channel_edges[0], with self._ax_resid.set_ylim([_np.max([channel_edges[0],0.001]), in _residual.py. Similar fixes should probably be done in other signal plot types.

This problem was encountered by @Sidewaysgravity79 .

@thjsal thjsal added the bug Something isn't working label Mar 5, 2024
@thjsal thjsal self-assigned this Mar 5, 2024
@thjsal thjsal added the hackweek2024 Issues to be fixed during the 2024 Hack Week label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hackweek2024 Issues to be fixed during the 2024 Hack Week
Projects
None yet
Development

No branches or pull requests

1 participant