Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use standard order #3

Open
yannickwurm opened this issue Nov 18, 2015 · 0 comments
Open

use standard order #3

yannickwurm opened this issue Nov 18, 2015 · 0 comments

Comments

@yannickwurm
Copy link
Member

some examples use gsub(pattern = '', replacement = "", x = "")
We should in general use x first - thus those examples should be reversed.

The situation where x can justifiably be last is when pattern and repl are unchanged and x is the only thing that changes. Having x at the end in such situations would increase legibility...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant