Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating password should be done in provision task #879

Open
pun-ky opened this issue Mar 11, 2022 · 2 comments
Open

Updating password should be done in provision task #879

pun-ky opened this issue Mar 11, 2022 · 2 comments
Labels

Comments

@pun-ky
Copy link
Contributor

pun-ky commented Mar 11, 2022

https://github.com/wttech/gradle-aem-plugin/blob/master/src/main/kotlin/com/cognifide/gradle/aem/common/instance/LocalInstance.kt#L308

the side effect possible is that when calling instanceUp task is implemented as starting systemd service, then when instance is already up then there is no effective trigger that will cause updating password.

as a workaround now AEM instance need to be manually restarted in such case or additional instanceUp gradle task call need to be run to have desired password set up.

to be implemented as provisioner built-in step or explicitly defined

provisioner { updateAdminPassword() }

reported by @krzysztofadamowski

@pun-ky pun-ky added the major label Mar 11, 2022
@krystian-panek-vmltech
Copy link
Collaborator

krystian-panek-vmltech commented Jul 14, 2022

hmm or it could stay as is but password should be provided as environment variable passed to the VM via custom_data (cloud init) as mentioned in wttech-private/gat#235

and GAP should be able to read that value; e.g when there is no instance.default.password assigned GAP will read value from AEM_INSTANCE_PASSWORD env var

@krystian-panek-vmltech
Copy link
Collaborator

env var need to be somehow injected here if password is not explicitly defined as Java property

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants