Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I reach the end of the Reader feed #23799

Open
dzver opened this issue Nov 13, 2024 · 3 comments
Open

I reach the end of the Reader feed #23799

dzver opened this issue Nov 13, 2024 · 3 comments

Comments

@dzver
Copy link

dzver commented Nov 13, 2024

Expected behavior

I expect the Reader feed to not end

Actual behavior

It sometimes ends, and when it ends, I can't resume it. Going back and forth doesn't fix it, it doesn't restart when I scroll up

ScreenRecording_11-13-2024.15-41-45_1.mov

Steps to reproduce the behavior

Scroll until it ends

Tested on [device], iOS [version], Jetpack iOS / WordPress iOS [version]

iPhone 15 Pro

@dangermattic
Copy link
Collaborator

dangermattic commented Nov 13, 2024

Thanks for reporting! 👍

@kean
Copy link
Contributor

kean commented Nov 13, 2024

Hey, thanks for the report!

@kean
Copy link
Contributor

kean commented Nov 14, 2024

RCA – likely one of these criteria:

    private func syncMoreContentIfNeeded(for tableView: UITableView, indexPathForVisibleRow indexPath: IndexPath) {
        let criticalRow = tableView.numberOfRows(inSection: indexPath.section) - loadMoreThreashold
        guard let syncHelper = syncHelper, (indexPath.section == tableView.numberOfSections - 1) && (indexPath.row >= criticalRow) else {
            return
        }
        let shouldLoadMoreItems = syncHelper.hasMoreContent
        && !syncHelper.isSyncing
        && !cleanupAndRefreshAfterScrolling
        && !siteBlockingController.isBlockingPosts
        && !readerPostService.isSilentlyFetchingPosts
        if shouldLoadMoreItems {
            syncHelper.syncMoreContent()
        }
    }

I don't know why it has to be this complicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants