Support SPM installation #1379
Support SPM installation #1379
Conversation
| @@ -967,8 +967,7 @@ | |||
| F1DC21B22199D58B007C189E /* ElementToAttributedString */, | |||
| F1E75630215B0C9E004BC254 /* StringAttributesToAttributes */, | |||
| ); | |||
| name = Converters; | |||
| path = "New Group"; | |||
| path = Converters; | |||
There was a problem hiding this comment.
I noticed that this group was not properly renamed on disk and renamed it so it shows up correctly in SPM.
There was a problem hiding this comment.
This file is not part of the Xcode project, but SPM was picking it up and failing to compile.
There was a problem hiding this comment.
This file is not part of the Xcode project, but SPM was picking it up and failing to compile.
|
I just want to say thanks for the awesome library. I know I didn't ask about adding this support before opening the PR, it's ok if this doesn't align with your goal, though. I had trouble finding your project when looking to solve what this solves, and I'd love to get it listed in the swift package index if this goes through. |
allenhumphreys
force-pushed
the
ah/spm
branch
from
aaeb244
to
1719ce9
Compare
|
good job @allenhumphreys |
|
Thanks for the work here @allenhumphreys – I'm in the midst of reviewing this, but it may take a few more days. Just wanted to provide an update. |
Fixes #1372 #1370
To test:
You can add
.package(url: "https://github.com/allenhumphreys/AztecEditor-iOS", branch: "ah/spm")to the dependencies in a sample application. If needed I can create a repo with a sample application that consumes the package.CHANGELOG.mdif necessary.