Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0.0 - Some events not being tracked in Empty Cart #389

Open
puntope opened this issue Mar 11, 2024 · 1 comment
Open

v2.0.0 - Some events not being tracked in Empty Cart #389

puntope opened this issue Mar 11, 2024 · 1 comment
Labels
type: bug The issue/PR is a confirmed bug. v2.0.0 Related to version >= 2.0.0

Comments

@puntope
Copy link
Contributor

puntope commented Mar 11, 2024

Describe the bug:

In the Cart Empty page when clicking to Add To Cart a fatal error is shown.

Screen.Recording.2024-03-11.at.17.00.46.mov

⚠️ Aditionally, other events like "view_item_list", "select_content" are not being triggered.

Steps to reproduce:

  1. Go to Cart page without any item in the cart
  2. ⚠️ See the products, but "view_item_list" is not triggered
  3. Click on "Add to cart" in the products shown.
  4. ⚠️ See the error in the console
  5. ⚠️ "add_to_cart" event is not being tracked.
  6. Click on the product image
  7. ⚠️ "select_content" is not triggered.

Expected behavior:

  1. Go to Cart page without any item in the cart
  2. See the products, but "view_item_list" is triggered
  3. Click on "Add to cart" in the products shown.
  4. "add_to_cart" event is being tracked.
  5. Click on the product image
  6. "select_content" is triggered.
@puntope puntope added type: bug The issue/PR is a confirmed bug. v2.0.0 Related to version >= 2.0.0 labels Mar 11, 2024
@mikkamp
Copy link
Contributor

mikkamp commented Mar 12, 2024

The fatal error should no longer be reproducible after #386
Since in add_to_cart it will return an empty list if the product was not found.

That still doesn't take away from the problem that those products aren't found, and hence the other events can't be tracked, but that would have a lower priority.

@puntope puntope changed the title v2.0.0 - Fatal error on Empty Cart when adding a product v2.0.0 - Some events not being tracked in Empty Cart Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug The issue/PR is a confirmed bug. v2.0.0 Related to version >= 2.0.0
Projects
None yet
Development

No branches or pull requests

2 participants