Hide express payment buttons on switch subscription page #3610
+12
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mayisha
requested review from
a team and
wjrosa
and removed request for
a team
wjrosa
reviewed
Nov 18, 2024
| @@ -85,6 +85,11 @@ public function init() { | |||
| return; | |||
| } | |||
|
|
|||
| // Don't load for switch subscription page. | |||
| if ( isset( $_GET['switch-subscription'] ) ) { | |||
| return true; | |||
There was a problem hiding this comment.
Is there a particular reason for the true value here? I'm just asking because the other return statements above do not have a value (void).
There was a problem hiding this comment.
Good catch. I added this check inside another function (which should return a boolean) at first and copied it over from there. It is a copy paste error on my end 🤦♀️
Fixed in 2a0929f
wjrosa
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Nice fix, Mayisha! Works as expected:
On this branch, you should not see the ECE button on the switch subscription page.
Confirm that the ECE buttons are rendered correctly on cart and checkout pages when you click the switch button and it is added to the cart.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3608
Changes proposed in this Pull Request:
As switch subscription page is basically the product page, when paid with ECE/PRB the full amount is charged instead of the difference. We are hiding the PRB/ECE buttons from the switch subscription page.
Testing instructions
WooCommerce Subscriptionplugin.developbranch, you can see the ECE button on this page.