Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigation: Making express checkout work even when cards are not enabled #3593

Open
annemirasol opened this issue Nov 6, 2024 · 0 comments
Labels
component: ECE Issues related to Express Checkout Element type: enhancement The issue is a request for an enhancement / Feature Request

Comments

@annemirasol
Copy link
Contributor

Is your feature request related to a problem? Please describe.

When credit cards are not enabled, using Apple Pay/Google Pay in an order will result in an Invalid payment method error. This is because checkout fails WooCommerce validation due to the stripe payment gateway not being available.

Image

When the payment gateway validation part is forcibly skipped (e.g. by commenting it out), payment succeeds and the order pushes through without any problem (AFAICT).

This issue was created in order to revisit the decision made in #3589 to hide express checkout when cards are disabled.

Describe the solution you'd like

We should investigate, discuss and document the following points:

  1. Do we want to make express checkout work, even when credit cards are not enabled? Are there practical use cases for such a setup?
  2. Should we be using stripe as the gateway ID for credit card payments? Should we be using stripe as the gateway ID for express checkout?
  3. Can we safely skip gateway validation for express payment methods?
@annemirasol annemirasol added component: ECE Issues related to Express Checkout Element type: enhancement The issue is a request for an enhancement / Feature Request labels Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ECE Issues related to Express Checkout Element type: enhancement The issue is a request for an enhancement / Feature Request
Projects
None yet
Development

No branches or pull requests

1 participant