Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node/npm engines #32

Closed
helgatheviking opened this issue Apr 1, 2024 · 2 comments · Fixed by #41
Closed

Update node/npm engines #32

helgatheviking opened this issue Apr 1, 2024 · 2 comments · Fixed by #41
Milestone

Comments

@helgatheviking
Copy link

@wordpress/scripts requires node 18+. npm run packages-update produces the following

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '@wordpress/[email protected]',
npm WARN EBADENGINE   required: { node: '>=18', npm: '>=6.14.4' },
npm WARN EBADENGINE   current: { node: 'v16.19.1', npm: '8.19.3' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '@wordpress/[email protected]',
npm WARN EBADENGINE   required: { node: '>=18' },
npm WARN EBADENGINE   current: { node: 'v16.19.1', npm: '8.19.3' }
npm WARN EBADENGINE }

.nvmrc is Node 16.

@dakota
Copy link

dakota commented Apr 9, 2024

@helgatheviking Thank you for reporting this!

It looks like the issue is that the npm run package-update changes the constraint for the @wordpress/scripts package to ^27.6.0 and forces it to be upgraded without any regard for other constraints in place (Such as the Node version).

We will schedule some time to look into upgrading the package and testing on Node 18, in the meantime skip the npm run package-update step.

@PanosSynetos
Copy link
Collaborator

Hey @helgatheviking - We're planning to upgrade this to node 20, to be on the same page as WooCommerce (which recently upgraded)

We'll ping you when done

@jimjasson jimjasson added this to the 1.0.9 milestone May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants