Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate output against WCAG 2.1 #5

Open
2 tasks
nielslange opened this issue Sep 23, 2021 · 5 comments
Open
2 tasks

Validate output against WCAG 2.1 #5

nielslange opened this issue Sep 23, 2021 · 5 comments
Labels
category: accessibility The issue/PR is related to accessibility.
Milestone

Comments

@nielslange
Copy link
Member

nielslange commented Sep 23, 2021

To make the plugin inclusive, the output needs to fulfil the WCAG 2.1 AA standard.

Tasks

  • Replace <div class="progress-container">...</div> with <progress>...</progress>
  • Add aria-valuemin, aria-valuemax and aria-valuenow to <progress> element

Sources

@nielslange nielslange added the category: accessibility The issue/PR is related to accessibility. label Sep 23, 2021
@nielslange nielslange added this to the i1 milestone Sep 23, 2021
@senadir
Copy link
Member

senadir commented Sep 24, 2021

What kind of output are you trying to validate exactly? The text shouldn't have a colour by default, and should just inherent the colour provided by the theme. From what I understood from Viv, the text shouldn't be on top of the progress bar, those two should be separate. The progress bar should inherit the text colour as well, unless otherwise.

@nielslange
Copy link
Member Author

The progress bar works on a color base. I need to ensure that the colors use a sufficient contrast. In addition, visually impaired users that use a scree reader must be able to understand the progress bar as well. Therefore, I need to add additional text for the screen reader.

@senadir
Copy link
Member

senadir commented Sep 24, 2021

I'm not sure I'm following. To know if you have enough contrast, you need to know the colour offhand, which is not possible here given you shouldn't be providing a colour for the progress bar.

@senadir
Copy link
Member

senadir commented Sep 24, 2021

I'd (if I'm understanding the requirements correctly), this issue should be blocked by #6.
Why?

  • You can't compare contrast unless you have two colors, background and foreground.
  • By default, the block should inherit the theme colors for background (transparent) and text. You can't have access to those colors in JS.
  • Once Make color editable #6 is done, Gutenberg offers utilities that allow you to check contrast, by providing an explicit background and foreground color.

@nielslange
Copy link
Member Author

Your explanation makes sense, @senadir. I'll deprioritize this issue accordingly.

@nielslange nielslange modified the milestones: i1, i2 Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: accessibility The issue/PR is related to accessibility.
Projects
None yet
Development

No branches or pull requests

2 participants