Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GTIN] Adjust plugin version for hidding GTIN #2678

Merged
merged 1 commit into from
Nov 19, 2024
Merged

[GTIN] Adjust plugin version for hidding GTIN #2678

merged 1 commit into from
Nov 19, 2024

Conversation

puntope
Copy link
Contributor

@puntope puntope commented Nov 18, 2024

Changes proposed in this Pull Request:

Closes #2648

This PR adjusted the G4W version to 2.8.8. This version number is used to hide GTIN field for new users.

Screenshots:

Detailed test instructions:

  1. Use a G4W version lower than 2.8.8
  2. Go to a product and see that GTIN field is read only under Google for WooCommerce tab
  3. Patch the plugin version to 2.8.8 or higher
  4. Go to a product and see that GTIN field is not visible anymore under Google for WooCommerce tab

Additional details:

Changelog entry

Tweak - Adjust plugin version to hide GTIN

@github-actions github-actions bot added the changelog: tweak Small change, that isn't actually very important. label Nov 18, 2024
@puntope puntope changed the base branch from develop to add/support-core-gtin-field November 18, 2024 07:59
@puntope puntope self-assigned this Nov 18, 2024
@puntope puntope requested a review from a team November 18, 2024 07:59
@codecov Codecov
Copy link

codecov bot commented Nov 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.4%. Comparing base (b833f0c) to head (0069fb5).
Report is 3 commits behind head on add/support-core-gtin-field.

Files with missing lines Patch % Lines
src/HelperTraits/GTINMigrationUtilities.php 0.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                       Coverage Diff                       @@
##             add/support-core-gtin-field   #2678     +/-   ##
===============================================================
- Coverage                           64.9%   64.4%   -0.5%     
  Complexity                          4667    4667             
===============================================================
  Files                                478     799    +321     
  Lines                              19517   24647   +5130     
  Branches                               0    1242   +1242     
===============================================================
+ Hits                               12674   15875   +3201     
- Misses                              6843    8599   +1756     
- Partials                               0     173    +173
Flag Coverage Δ
js-unit-tests 62.4% <ø> (?)
php-unit-tests 64.9% <0.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/HelperTraits/GTINMigrationUtilities.php 29.6% <0.0%> (ø)

... and 321 files with indirect coverage changes

---- 🚨 Try these New Features:

@puntope puntope marked this pull request as ready for review November 18, 2024 08:02
mikkamp
mikkamp approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@mikkamp mikkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@puntope puntope merged commit 0831421 into add/support-core-gtin-field Nov 19, 2024
17 checks passed
@puntope puntope deleted the tweak/adjust-wc-version-gtin branch November 19, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikkamp mikkamp mikkamp approved these changes

Assignees

@puntope puntope

Labels
changelog: tweak Small change, that isn't actually very important.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[GTIN] Set Extension version to the right version after releasing the feature
2 participants
@puntope @mikkamp