-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In content shortcuts anchors broken #162
Comments
Can we just manually update them for now on the develop branch? |
@LukeTowers Is somebody working on this? |
@bennothommo ping |
@damsfx the helpers page appears to be fixed now, do you want to submit a PR for the other ones? |
@LukeTowers I was going to fix the validation and collection ones at the same time, the problem though was that anchoring the rules/commands in those pages results in every validation rule / collection method appearing in the Table of Contents (anchors must be a H2 or H3). I wasn't sure if that was gonna be acceptable or not, so I left it. |
@LukeTowers I wanted to do it ... but I'm having trouble setting up the documentation locally to test my changes. @bennothommo I had the same thought as you when I looked at the documentation plugin code. |
@bennothommo @damsfx I'm fine with the TOC being made bigger on those pages, eventually we'll reorganize the docs to have more pages with less content on each page so it's easier to find information by browsing around, but for now having them in the TOC should be fine. If necessary it would be nice if they could be collapsible, but that's not a hard requirement. |
On some docs pages, in text columned-list shortcuts don't work.
The three pages where I find the issue for now :
https://wintercms.com/docs/v1.2/docs/services/helpers top shortcuts
https://wintercms.com/docs/v1.2/docs/services/validation#available-validation-rules
https://wintercms.com/docs/v1.2/docs/services/collections#available-methods
For the Helpers top shortcuts, anchors need to be updated to remove "_".
For Validation (available validation rules) and Collections (available methods), the corresponding anchors doesn't exists in the rendered page.
The text was updated successfully, but these errors were encountered: