You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I started out this library in a private repo and went with the simple naive approach of having a NavGroup and NavItem, one being able to have sub-items. But as this library has evolved, it's making less sense to keep them apart.
Recent changes (that have not been published in a new version, yet) have brought them even further together, with NavGroup only differing in a few ways.
The text was updated successfully, but these errors were encountered:
I think this is probably the correct way forward, but it will need to be handled gracefully. It's probably too much of a change for the upcoming release (it already has a ton of changes), so we can plan it for the next release.
Let's split it across two releases though:
Move all the functionality within NavItem and have a shell NavGroup that logs a warning about the deprecation when used.
Remove from the library after a bit of time has passed.
If time permits, a Django check might be nice. But that may be overkill and a warning on the NavGroup would probably suffice.
I started out this library in a private repo and went with the simple naive approach of having a
NavGroup
andNavItem
, one being able to have sub-items. But as this library has evolved, it's making less sense to keep them apart.Recent changes (that have not been published in a new version, yet) have brought them even further together, with
NavGroup
only differing in a few ways.The text was updated successfully, but these errors were encountered: