Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify revert before "Add a custom module" in workshop #390

Open
chrismayer opened this issue May 16, 2024 · 0 comments
Open

Clarify revert before "Add a custom module" in workshop #390

chrismayer opened this issue May 16, 2024 · 0 comments
Labels
docs Documentation (API-Docs, Website, etc.) enhancement good first issue Good starting point for new developers

Comments

@chrismayer
Copy link
Collaborator

There is one thing that would deserve to be fixed in the workshop as we finish the "Use a module" part with a modified theme (pink borders and footer texts changed) then do the "Custom functionality" part as if we didn't make those changes and didn't add the layers and zoom-to-max-extent modules to eventually get to the "Add a custom module" part which resumes as if "Custom functionality" didn't exist...
I tried to find how changes could be minimized at that time and think we could address this by taking new screenshots for the "Custom functionality" part and change the beginning text of "Add a custom module" with something like

So far we modified the functionality of Wegue using the configuration file or by writing code into WguApp.vue. Now we will create a custom module using JavaScript. First we will revert what was made in WguApp.vue in the previous section. Then, to effectively create the custom module, we need to change a couple of files:

Based on a comment in #389 by @sronveaux

@chrismayer chrismayer added enhancement docs Documentation (API-Docs, Website, etc.) labels May 16, 2024
@chrismayer chrismayer changed the title Clarify introdution to "Add a custom module" in workshop Clarify revert before "Add a custom module" in workshop May 16, 2024
@chrismayer chrismayer added the good first issue Good starting point for new developers label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation (API-Docs, Website, etc.) enhancement good first issue Good starting point for new developers
Projects
None yet
Development

No branches or pull requests

1 participant