Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not assign to Vue.prototype in unit tests #388

Open
chrismayer opened this issue May 6, 2024 · 0 comments
Open

Do not assign to Vue.prototype in unit tests #388

chrismayer opened this issue May 6, 2024 · 0 comments
Labels
enhancement tests

Comments

@chrismayer
Copy link
Collaborator

The assignment of $appConfig (and maybe other properties) on Vue.prototype directly inside unit tests is considered bad practice. We should create a local Vue instance and assign to this local instance in place of the global one.

At least affects LocaleSwitcher.spec.js and Locale.spec.js.

Found in #387 by @sronveaux
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chrismayer