Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purge AppTemplate to contain only minimal definitions #276

Open
fschmenger opened this issue Jan 11, 2022 · 0 comments
Open

Purge AppTemplate to contain only minimal definitions #276

fschmenger opened this issue Jan 11, 2022 · 0 comments

Comments

@fschmenger
Copy link
Collaborator

Currently, the Wegue app template created on app-init is quite verbose and contains a lot of definitions that a common user will hardly ever touch. Also - as Wegue is a work in progress - app templates (within app-starter) are changed quite frequently at the moment. This results in exhaustive merge operations, to incorporate all the new changes from app-starter/WguAppTemplate.vue (and also all the referenced templates) into an app/WguAppTemplate.vue created with a previous Wegue version.

The goal:
In an ideal world, the default app template should be probably as simple as that:

<template>
   <wgu-app/>
</template>

The following is just a rough outline of the involved tasks.

Step 1:
Refactor Wegue, in order to move

  • AppFooter.vue
  • AppHeader.vue
  • AppSidebar.vue
    from app-starter to the code base. Additionally a new module WguApp.vue will be created in the code base which will wrap the code with all default Wegue-module includes from the current 'WguAppTemplate.vue'.

Step 2:
We should come up with a sophisticated slot concept (it's already present but needs more work), so we do not lose any customizability options. This means <wgu-app> should contain slots that allow the user to e.g. replace the AppFooter or AppHeader implementations. Hence the core should provide meaningful base classes for those, so a derived customized AppHeader can be implemented by a user with minimal effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant