Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is not a good idea for using node-schedule in a Puppet implementation. #327

Open
2 tasks
su-chang opened this issue Feb 28, 2022 · 2 comments
Open
2 tasks
Labels

Comments

@su-chang
Copy link
Member

See detail here: #322 (comment)

  • setTimeout
  • node-schedule
@hcfw007
Copy link
Member

hcfw007 commented Feb 28, 2022

If node-schedule package has no known issue, i think it's fine to use this package.

I mean there's no need to create a new wheel if the existing one is just fine, and there will possibly be more scheduled jobs in the future that could use node-schedule like clearing cache.

@huan
Copy link
Member

huan commented Feb 28, 2022

After I quickly reviewed the code I can not see any necessity to use this pattern.

It only adds up the complexity and can be simply replaced by setTimeout with a few lines of code I think.

However, I'm ok if both of you feel better by using node-schedule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants