Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure-metrics-exporter: The fix for namespaceSelector breaks the deployment #60

Open
ThomasMinor opened this issue Sep 17, 2024 · 3 comments · May be fixed by #65
Open

azure-metrics-exporter: The fix for namespaceSelector breaks the deployment #60

ThomasMinor opened this issue Sep 17, 2024 · 3 comments · May be fixed by #65

Comments

@ThomasMinor
Copy link

The addition of a namespaceSelector breaks the deployment in our environment throwing a nil pointer error:

Error: template: azure-metrics-exporter/templates/prometheus/servicemonitor.metricprobe.yaml:23:16: executing "azure-metrics-exporter/templates/prometheus/servicemonitor.metricprobe.yaml" at <.Values.prometheus.monitor.namespaceSelector>: nil pointer evaluating interface {}.prometheus

@ThomasMinor ThomasMinor changed the title The fix for namespaceSelector breaks the deployment azure-metrics-exporter: The fix for namespaceSelector breaks the deployment Sep 17, 2024
@ThomasMinor
Copy link
Author

Is addressed by #62

@Moglum
Copy link

Moglum commented Nov 4, 2024

#62 fixed only part of the problem. We're still getting:

Error: template: azure-metrics-exporter/templates/_helpers.tpl:36:16: executing "azure-metrics-exporter.namespace" at <.Values.namespaceOverride>: nil pointer evaluating interface {}.namespaceOverride

It's caused by passing the local scope instead of $root here https://github.com/webdevops/helm-charts/blob/main/charts/azure-metrics-exporter/templates/prometheus/servicemonitor.metricprobe.yaml#L28

I'll open a PR to fix it shortly.

@x418
Copy link
Contributor

x418 commented Nov 4, 2024

#62 fixed only part of the problem. We're still getting:

Error: template: azure-metrics-exporter/templates/_helpers.tpl:36:16: executing "azure-metrics-exporter.namespace" at <.Values.namespaceOverride>: nil pointer evaluating interface {}.namespaceOverride

It's caused by passing the local scope instead of $root here https://github.com/webdevops/helm-charts/blob/main/charts/azure-metrics-exporter/templates/prometheus/servicemonitor.metricprobe.yaml#L28

I'll open a PR to fix it shortly.

My bad. I saw the comment too late (after the merge). Thanks for taking care of it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants