Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version numbers backwards... #15

Open
digitalmoksha opened this issue Aug 7, 2015 · 2 comments
Open

version numbers backwards... #15

digitalmoksha opened this issue Aug 7, 2015 · 2 comments

Comments

@digitalmoksha
Copy link
Contributor

It seems that the version numbers are backwards. In RubyMotion., version maps to CFBundleVersion, and short_version maps to CFBundleShortVersionString.

In an OSX app, the CFBundleShortVersionString is the real app's version number, and CFBundleVersion is the build number. The build number should typically be an increasing number, and is usually pulled from the git commit, or something.

motion-sparkle seems to have these numbers backwards, and so creates the package with values such as this

Release 82 (0.8.1)
Version 82
Build 0.8.1

instead of the correct

Release 0.8.1 (82)
Version 0.8.1
Build 82
@webcracy
Copy link
Owner

webcracy commented Aug 7, 2015

Ouch, thanks for the report.

Do you think you can submit a PR? I'll take a look otherwise.

Cheers

On Aug 7, 2015, at 10:13, digitalMoksha [email protected] wrote:

It seems that the version numbers are backwards. In RubyMotion., version maps to CFBundleVersion, and short_version maps to CFBundleShortVersionString.

In an OSX app, the CFBundleShortVersionString is the real app's version number, and CFBundleVersion is the build number. The build number should typically be an increasing number, and is usually pulled from the git commit, or something.

motion-sparkle seems to have these numbers backwards, and so creates the package with values such as this

Release 82 (0.8.1)
Version 82
Build 0.8.1
instead of the correct

Release 0.8.1 (82)
Version 0.8.1
Build 82

Reply to this email directly or view it on GitHub.

@digitalmoksha
Copy link
Contributor Author

No problem. I do have one, but it's built on the other PR's i've submitted (and one other one, which uses the ksuther xpc branch for supporting sanboxed apps). I have to figure out the best way to separate it out, then I will be happy to submit it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants