Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocked modal overlay flashes briefly sometimes when browsing web3.storage website #1998

Closed
dchoi27 opened this issue Oct 4, 2022 · 2 comments · Fixed by #2089
Closed

Blocked modal overlay flashes briefly sometimes when browsing web3.storage website #1998

dchoi27 opened this issue Oct 4, 2022 · 2 comments · Fixed by #2089
Assignees
@e-schneid
Labels
kind/bug A bug in existing code (including security flaws) pi/dotstorage-site-improvements Improvements to web3 and nft websites

Comments

@dchoi27
Copy link
Contributor

dchoi27 commented Oct 4, 2022

Sometimes, when clicking through the web3.storage website, a modal pops up for a split second. I've seen this on pretty much all pages of the website, including the docs.

From what I can read in the brief time it's up, I'm pretty sure it's this: https://github.com/web3-storage/web3.storage/blob/main/packages/website/components/account/accountBlockedModal/accountBlockedModal.js

Potentially we are making it appear by default, rather than just making it appear if the account is supposed to be blocked? Also it might not be this exact modal (the word "blocked" is definitely in it), but if it is, we should consider not making it appear on any page except the account page (potentially we call it whenever you're in the logged in state).
@dchoi27 dchoi27 added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization pi/dotstorage-site-improvements Improvements to web3 and nft websites labels Oct 4, 2022
@JeffLowe
Copy link

JeffLowe commented Oct 5, 2022

Might be related to a rendering issue we are fixing in #1953
Just in case, assigning this to @e-schneid

@JeffLowe JeffLowe removed the need/triage Needs initial labeling and prioritization label Oct 5, 2022
@e-schneid
Copy link
Contributor

@dchoi27 @JeffLowe I haven't been able to reproduce this and I can't see a scenario in the code where this would happen, but it looks like right now the account blocked modal component will always render in the DOM and we just hide it with CSS. I'll push up a tiny change to prevent the Account Blocked modal from rendering at all (hidden by CSS or otherwise) unless the user's account is restricted. This is at least an optimization and perhaps an additional safeguard against the modal displaying when it shouldn't. @dchoi27, If it continues to display for you after this change please reopen it and I'll do some more investigating.

@e-schneid e-schneid mentioned this issue Nov 1, 2022
Merged
@e-schneid e-schneid linked a pull request Nov 1, 2022 that will close this issue
fix: do not render account blocked modal unless account restricted #2089
Merged
jsdevel pushed a commit that referenced this issue Nov 9, 2022
@e-schneid
fix: do not render account blocked modal unless account restricted (#…
1025a22 
…2089)

Closes #1998 

There's a reported issue where the Account Blocked modal displays
briefly when navigating the site. I haven't yet been able to reproduce
this, but currently this modal always renders (and is just hidden with
CSS). This PR is an optimization to prevent the modal from rendering at
all. It will hopefully resolve the issue, but it will also reduce the
size of the prerendered HTML.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@e-schneid e-schneid

Labels
kind/bug A bug in existing code (including security flaws) pi/dotstorage-site-improvements Improvements to web3 and nft websites
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: do not render account blocked modal unless account restricted web3-storage/web3.storage
3 participants
@JeffLowe @dchoi27 @e-schneid