Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Auth: userSignupFields and getConfig: we don't say they need to be server/nodejs code? #2342

Open
Martinsos opened this issue Oct 17, 2024 · 0 comments
Labels
documentation Improvements or additions to documentation shouldfix We should do/fix this at some point

Comments

@Martinsos
Copy link
Member

We had a user getting errors here because we was importing these functions from .jsx file: https://discord.com/channels/686873244791210014/1296186131918098536/1296186131918098536 .

I looked in the docs and I don't see however that we say somewhere that these functions have to be server code (actually, taht they can't be client code - because they can also certainly be isomorphic). We should probably say so!

This touches the general question of should we have a way of distinguishing between client and the server code, e.g. files having .server.js or .client.js extensions. Or should it be .node.js / .bun.js / .deno.js? Wild!

Also, the question of should we always make it clear in our docs if function shoudl be client or server code and maybe having a mechanism to easily implement that in the docs.

@Martinsos Martinsos added the documentation Improvements or additions to documentation label Oct 17, 2024
@infomiho infomiho added the shouldfix We should do/fix this at some point label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation shouldfix We should do/fix this at some point
Projects
None yet
Development

No branches or pull requests

2 participants