Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query cache hits scramble timings #139

Open
favila opened this issue Jun 13, 2023 · 1 comment
Open

query cache hits scramble timings #139

favila opened this issue Jun 13, 2023 · 1 comment
Milestone

Comments

@favila
Copy link

favila commented Jun 13, 2023

When using the query cache and when a query is a cache "hit", the ::timing-start value that is used is the value from the initially-cached query, not from the current request.

The bug is this line, which returns the cached value unchanged instead of associng the "fresh" timing-start value passed in to the function.

As an additional wrinkle, the parsing timing info is also cached, so the value reported is really only relevant for the initial request. I'm not sure what to do here. A possibility is to time the cache lookup and regard that as the parse offset+duration if it's a "hit".

(Related because also a timing bug: walmartlabs/lacinia#448)

@hlship
Copy link
Member

hlship commented Sep 28, 2023

This does look like an issue, thanks for researching it so thoroughly.

@hlship hlship added this to the 1.2.1 milestone Sep 28, 2023
@hlship hlship modified the milestones: 1.3, 1.3.1 Jul 12, 2024
@hlship hlship modified the milestones: 1.3.1, 1.3.2 Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants