Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore:pubsub topic && content_topic encoding is optional #3128

Open
AYAHASSAN287 opened this issue Oct 17, 2024 · 0 comments
Open

chore:pubsub topic && content_topic encoding is optional #3128

AYAHASSAN287 opened this issue Oct 17, 2024 · 0 comments
Labels
effort/hours Estimated to be completed in a few hours

Comments

@AYAHASSAN287
Copy link

Background

When calling API get /store/v3/messages with pubsubTopic encoded or not encoded it works

[...]

Details

ex :
curl -v -X GET "http://127.0.0.1:49153/store/v3/messages?includeData=true&pubsubTopic=/waku/2/rs/3/0&pageSize=20&ascending=true"

or call it encoded
ex:

curl -v -X GET "http://127.0.0.1:5213/store/v3/messages?includeData=true&pubsubTopic=%2Fwaku%2F2%2Frs%2F3%2F0&pageSize=20&ascending=true"

in both cases it works ang got the message with correct topic name

Acceptance criteria

According to specs pubsubtopic shall be encoded

Image

so behavior and specs Don't match either specs shall mark the encoding as optional or SW change to mandatory

Note: same for content_topic

@gabrielmer gabrielmer moved this to To Do in Waku Oct 20, 2024
@gabrielmer gabrielmer added the effort/hours Estimated to be completed in a few hours label Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/hours Estimated to be completed in a few hours
Projects
Status: To Do
Development

No branches or pull requests

2 participants