Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C-Bindings Improvement: Callbacks and Duplications #629

Closed
3 tasks done
richard-ramos opened this issue Aug 4, 2023 · 3 comments
Closed
3 tasks done

C-Bindings Improvement: Callbacks and Duplications #629

richard-ramos opened this issue Aug 4, 2023 · 3 comments
Assignees
@richard-ramos
Labels
E:NodeJS Library See https://github.com/waku-org/pm/issues/81 for details

Comments

@richard-ramos
Copy link
Member

richard-ramos commented Aug 4, 2023 •
edited
Loading

Planned start date:
Due date:

Summary

Achieve feature parity with nwaku c-bindings changes

Acceptance Criteria

go-waku and nwaku have the same API for c-bindings

Tasks

RAID (Risks, Assumptions, Issues and Dependencies)
@richard-ramos richard-ramos added milestone Tracks a subteam milestone e:2023-c-bindings labels Aug 4, 2023
@richard-ramos richard-ramos self-assigned this Aug 4, 2023
@richard-ramos
Copy link
Member Author

richard-ramos commented Aug 4, 2023 •
edited by fryorcraken
Loading

Weekly Update

  • achieved: updated c-bindings to use callbacks
  • next: refactor v1 encoding functions and update RFC

@fryorcraken fryorcraken changed the title [Milestone] C-Bindings [Milestone] C-Bindings Improvement: Callbacks and Duplications Aug 7, 2023
@fryorcraken fryorcraken added this to Waku Aug 9, 2023
@richard-ramos
Copy link
Member Author

richard-ramos commented Aug 11, 2023 •
edited by fryorcraken
Loading

Weekly Update

  • achieved: PR for updating the RFC to use callbacks, and refactored the encoding functions

@fryorcraken fryorcraken changed the title [Milestone] C-Bindings Improvement: Callbacks and Duplications [Epic] C-Bindings Improvement: Callbacks and Duplications Aug 24, 2023
@fryorcraken fryorcraken added epic Tracks a yearly team epic (only for waku-org/pm repo) and removed milestone Tracks a subteam milestone labels Aug 24, 2023
@fryorcraken fryorcraken mentioned this issue Aug 29, 2023
Closed
4 tasks
@fryorcraken fryorcraken added E:NodeJS Library See https://github.com/waku-org/pm/issues/81 for details and removed E:2023-many-platforms epic Tracks a yearly team epic (only for waku-org/pm repo) labels Sep 22, 2023
@fryorcraken fryorcraken changed the title [Epic] C-Bindings Improvement: Callbacks and Duplications C-Bindings Improvement: Callbacks and Duplications Sep 22, 2023
@fryorcraken
Copy link
Collaborator

@richard-ramos this work was initiated due to the work on nwaku for the NodeJS library, right?

@github-project-automation github-project-automation bot moved this to Done in Waku Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richard-ramos richard-ramos

Labels
E:NodeJS Library See https://github.com/waku-org/pm/issues/81 for details
Projects
Waku
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@richard-ramos @chair28980 @fryorcraken