Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Store request should timeout in a few seconds #1189

Closed
kaichaosun opened this issue Aug 9, 2024 · 1 comment · Fixed by #1204
Closed

bug: Store request should timeout in a few seconds #1189

kaichaosun opened this issue Aug 9, 2024 · 1 comment · Fixed by #1204

Comments

@kaichaosun
Copy link
Contributor

kaichaosun commented Aug 9, 2024

Describe the bug
The store request with hash now takes a few minutes, waku api should return an error if reached timeout, the timeout should be a few seconds, how about 10s?

Related to issue: status-im/status-go#5449

cc @richard-ramos @chaitanyaprem @plopezlpz

@chaitanyaprem
Copy link
Collaborator

Describe the bug The store request with hash now takes a few minutes, waku api should return an error if reached timeout, the timeout should be a few seconds, how about 10s?

cc @richard-ramos @chaitanyaprem @plopezlpz

sounds like a good idea, but i don't think this should be addressed in go-waku. The caller (status-go) can just create a context with timeout and pass it to store request which would then get handled automatically.

The context is already there so that caller will have a choice to decide timeout in such scenarios.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants