Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow optimize and evm-version pragma's in .vyi files #3978

Open
pcaversaccio opened this issue Apr 26, 2024 · 4 comments
Open

Disallow optimize and evm-version pragma's in .vyi files #3978

pcaversaccio opened this issue Apr 26, 2024 · 4 comments
Assignees

Comments

@pcaversaccio
Copy link
Collaborator

pcaversaccio commented Apr 26, 2024

I don't think it makes any sense to have the optimize and evm-version pragma's in .vyi files. It might even give wrong implications that such an interface can only be imported and implementsed using these specific pragma directives.

@pcaversaccio
Copy link
Collaborator Author

This also includes the experimental-codegen pragma statement.

@charles-cooper
Copy link
Member

i guess we check that the settings object from pre_parsing is equal to Settings()

@cyberthirst
Copy link
Collaborator

this inspired me to test

# main.vy
import ITest

implements: ITest

@external
@view
def c() -> uint256:
    return 1
    
# ITest.vyi
c: public(transient(uint256))

compiles against 063f190

@sandbubbles
Copy link
Collaborator

I think there will be a straightforward solution once #4290 is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants