Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow same styling for navbar as parent site. #14

Open
theNaut1lus opened this issue Apr 16, 2019 · 1 comment
Open

Follow same styling for navbar as parent site. #14

theNaut1lus opened this issue Apr 16, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@theNaut1lus
Copy link

theNaut1lus commented Apr 16, 2019

Describe the bug
The navbar although looks very nice, seems to have some design in-consistencies with the navbar over at the parent website: https://vuejs.org

Most prominent being the search bar size and overall size of the elements in the navbar.

To Reproduce
Steps to reproduce the behavior:

  1. Open https://events.vuejs.org
  2. Open https://vuejs.org
  3. Spot the differences in design.

Expected behavior
This could be intentional as this is a separate repository but if it isn't then it seems like the navbar could be perhaps made consistent with the parent website.

Screenshots
Screenshot 2019-04-16 at 10 29 55 AM
Screenshot 2019-04-16 at 10 39 50 AM

Desktop (please complete the following information):

  • OS: macOS
  • Browser: Safari
  • Version: 12.1 (14607.1.40.1.4) [latest]

Additional context
If this is indeed sorted as a valid issue, would love to work on this as my first contribution here 🥇

@bencodezen bencodezen self-assigned this Apr 16, 2019
@bencodezen
Copy link
Member

Thanks for your feedback @co16353sidak! The current site is using the default theme from VuePress as its base design, but I think you make some good points as far as keeping it consistent with the parent website.

I'll be sure to take a look and make the appropriate changes.

@bencodezen bencodezen added the enhancement New feature or request label Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants