Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random values ​​at runtime and compilation errors when returning Result in a static method. #22894

Closed
gechandesu opened this issue Nov 17, 2024 · 0 comments · Fixed by #22896
Assignees
Labels
Bug This tag is applied to issues which reports bugs. Status: Confirmed This bug has been confirmed to be valid by a contributor. Unit: cgen Bugs/feature requests, that are related to the default C generating backend.

Comments

@gechandesu
Copy link

gechandesu commented Nov 17, 2024

V doctor:

V full version: V 0.4.8 5ec9bb5.5bba92a
OS: linux, Linux version 6.6.8-arch1-1 (linux@archlinux) (gcc (GCC) 13.2.1 20230801, GNU ld (GNU Binutils) 2.41.0) #1 SMP PREEMPT_DYNAMIC Thu, 21 Dec 2023 19:01:01 +0000
Processor: 16 cpus, 64bit, little endian, 12th Gen Intel(R) Core(TM) i5-1240P

getwd: /home/ge/Code/v/netaddr
vexe: /home/ge/.vlang/v
vexe mtime: 2024-11-17 19:31:14

vroot: OK, value: /home/ge/.vlang
VMODULES: OK, value: /home/ge/.vmodules
VTMP: OK, value: /tmp/v_1000

Git version: git version 2.46.1
Git vroot status: weekly.2024.46-55-g5bba92a6
.git/config present: true

CC version: cc (GCC) 14.2.1 20240910
emcc version: N/A
thirdparty/tcc status: thirdparty-linux-amd64 0134e9b9

What did you do?
./v -g -o vdbg cmd/v && ./vdbg arr_issue.v

module main

type Foo = [4]u8

fn Foo.new(el []u8) !Foo {
	if el.len != 4 {
		return error('el must have 4 members')
	}
	mut bytes := [4]u8{}
	for i := 0; i < 4; i++ {
		bytes[i] = el[i]
	}
	return Foo(bytes)
}

fn Foo.new_no_err(el []u8) Foo {
	mut bytes := [4]u8{}
	for i := 0; i < 4; i++ {
		bytes[i] = el[i]
	}
	return Foo(bytes)
}

fn (f Foo) str() string {
	return '${f[0]}, ${f[1]}, ${f[2]}, ${f[3]}'
}

fn main() {
	a := Foo.new_no_err([u8(5), 4, 3, 2])
	println(a) // works fine

	b := Foo.new([u8(1), 2, 3, 4])!
	println(b) // have different random result on each run instead of "1, 2, 3, 4"

	// code below does not compile with C error
	c := Foo.new([u8(1), 2, 3, 4]) or { Foo([u8(0), 0, 0, 0]!) }
	println(c)
}

What did you expect to see?

Variables b and c contain 1, 2, 3, 4. No random results and compilation errors.

What did you see instead?

================== C compilation error (from tcc): ==============
cc: /tmp/v_1000/arr_issue.01JCXT2DSRR2EGHQ12V2PQT3VT.tmp.c:13725: warning: cast between pointer and integer of different size
cc: /tmp/v_1000/arr_issue.01JCXT2DSRR2EGHQ12V2PQT3VT.tmp.c:13758: error: lvalue expected
... (the original output was 3 lines long, and was truncated to 2 lines)
=================================================================
(You can pass `-cg`, or `-show-c-output` as well, to print all the C error messages).
builder error: 
==================
C error found. It should never happen, when compiling pure V code.
This is a V compiler bug, please report it using `v bug file.v`,
or goto https://github.com/vlang/v/issues/new/choose .
You can also use #help on Discord: https://discord.gg/vlang .

Note

You can use the 👍 reaction to increase the issue's priority for developers.

Please note that only the 👍 reaction to the issue itself counts as a vote.
Other reactions and those to comments will not be taken into account.

Huly®: V_0.6-21337

@felipensp felipensp self-assigned this Nov 17, 2024
@felipensp felipensp added Bug This tag is applied to issues which reports bugs. Status: Confirmed This bug has been confirmed to be valid by a contributor. Unit: cgen Bugs/feature requests, that are related to the default C generating backend. labels Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This tag is applied to issues which reports bugs. Status: Confirmed This bug has been confirmed to be valid by a contributor. Unit: cgen Bugs/feature requests, that are related to the default C generating backend.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants