Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proposal] users should be able to decide if they want some attributes also in contract storage #51

Open
mirceanis opened this issue Mar 30, 2023 · 1 comment

Comments

@mirceanis
Copy link
Contributor

Contract methods that update the DID document should also have a flag (or a variant) that also stores the attributes in contract storage, besides emitting the event.

This would be useful for partial on-chain resolution.

We also need to be mindful of revocation of attributes as these would have to also revoke the potentially stored data, regardless of the flag.

@jac18281828
Copy link
Collaborator

jac18281828 commented Sep 28, 2023

I support this idea as a variant function. I believe XMTP would use this api.

We can support revocation by overwriting and deleting the element from the storage map. A simple key value map is probably sufficient for this.

Does it make sense to implement an eternal storage contract for this purpose so that the storage element is separated from the registry logic? That would be a very simple contract but it could make sense from a design perspective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants