Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving ESM and SvelteKit support #115

Open
lachlancollins opened this issue Aug 13, 2022 · 0 comments
Open

Improving ESM and SvelteKit support #115

lachlancollins opened this issue Aug 13, 2022 · 0 comments

Comments

@lachlancollins
Copy link

Hi, my team have recently started using this package in our SvelteKit app, and I decided to look into the SvelteKit warning messages and complex instructions for what should be a simple import (e.g. #27).

At this point I have a strong suspicion this has to do with the rollup config and settings in the bundled package.json, but I've also noticed that the repo only contains the code to build the docs, not the npm package.

It's obviously a huge plus to have interactive docs, but I think this repo could benefit from a restructure to include the config to bundle and package the carousel, which could then be changed to improve the compatibility with the CJS/ESM ecosystems.

One way to go about this would be to use a monorepo structure (e.g. docs/ and package/ folders) with separate package.json files and separate dev/build commands. An alternative would be to use SvelteKit and its built-in packaging system (which is still experimental).

I think the simpler option would be just a monorepo. Please let me know your thoughts, I'm very happy to make a PR if you like this idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant