Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peerStore[AddressBook] missing remote endpoints of established connection. #1210

Open
cheatfate opened this issue Oct 4, 2024 · 2 comments
Assignees

Comments

@cheatfate
Copy link
Contributor

Current version of peerStore[AddressBook] holds only addresses which was announced by the peer itself during identify phase, but did not holds remote peer address of currently established connections.
For example nim-libp2p holds this data for fully connected peer via Internet.

/ip4/10.81.2.114/tcp/32502, /ip4/127.0.0.1/tcp/32502, /ip4/10.81.2.114/udp/32503/quic-v1, /ip4/127.0.0.1/udp/32503/quic-v1

As you can see there is no globally routable IP addresses available, which i think is incorrect.

@diegomrsantos
Copy link
Contributor

This can be achieved using

observedAddr*: Opt[MultiAddress]

@github-project-automation github-project-automation bot moved this from new to done in nim-libp2p Oct 10, 2024
@diegomrsantos diegomrsantos self-assigned this Oct 10, 2024
@kaiserd kaiserd reopened this Oct 15, 2024
@github-project-automation github-project-automation bot moved this from done to In Progress in nim-libp2p Oct 15, 2024
@kaiserd kaiserd moved this from In Progress to backlog in nim-libp2p Oct 15, 2024
@cheatfate
Copy link
Contributor Author

cheatfate commented Oct 16, 2024

Connection object is NOT easily accessible and needs to be accounted in nimbus-eth2 to properly access this value, its an overhead for application, imho. This functionality should be accessible via peerStore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: backlog
Development

No branches or pull requests

3 participants