Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highcharts module offline-exporting.js is not included #519

Open
WoozyG opened this issue Apr 24, 2018 · 2 comments
Open

Highcharts module offline-exporting.js is not included #519

WoozyG opened this issue Apr 24, 2018 · 2 comments

Comments

@WoozyG
Copy link

WoozyG commented Apr 24, 2018

This isn't loaded as part of HighchartsScriptLoader, but should be, or at least should be an option. Until it is, how should I go about getting the proper version loaded, preferably in a way that doesn't break when the Highcharts version is bumped?

@johannesh2
Copy link
Contributor

Thanks for the report. Adding to 4.1. In the meantime, maybe @alvarezguille can give you some way to load it.

@johannesh2 johannesh2 added this to the 4.1 milestone Apr 25, 2018
@alvarezguille
Copy link
Member

I did a small example of how to add one Highcharts extension some time ago, you can check it in
https://github.com/alvarezguille/charts-export-csv
Main steps are explained in readme
Regarding the version compatibility, I did a smoke test and the module for Highcharts 4.2.6 seems to work even with Highcharts latest version https://jsfiddle.net/alvarezg/vLjb5fa0/. Anyway once it's included in Vaadin Charts and released you should probably remove the resource loading from your project.
If you want to play safe you can check that the module is not there before loading, something similar to this snippet https://github.com/vaadin/charts/blob/master/addon/src/main/java/com/vaadin/addon/charts/client/HighchartsScriptLoader.java#L84-L89 but checking for Highcharts.CanVGRenderer

@alvarezguille alvarezguille removed this from the 4.1 milestone Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants