Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix serious errors in optimal filters' predicted variance and VdV #307

Open
joefowler opened this issue Nov 13, 2024 · 0 comments · May be fixed by #311
Open

Fix serious errors in optimal filters' predicted variance and VdV #307

joefowler opened this issue Nov 13, 2024 · 0 comments · May be fixed by #311
Assignees
@joefowler

Comments

@joefowler
Copy link
Member

At least the ArrivalTimeSafeFilters have a serious problem in how their predicted variance and VdV values are computed. Revisit, and get it right. Break the API if needed--it's better than just being wrong.
@joefowler joefowler self-assigned this Nov 13, 2024
joefowler added a commit that referenced this issue Nov 15, 2024
@joefowler
Correct computation of VdV and filter variances
db8dd78 
Fixes #307
@joefowler joefowler linked a pull request Nov 15, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joefowler joefowler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix optimal filters' VdV and variance calculations usnistgov/mass
1 participant
@joefowler