You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are different solidity versions we need to deal with. Potentially, we could go with let's say instead of solgo.parser into its own repository where we have parser.NewManager() and from which, with generics, we can load different types of parsers for different solidity versions.
Additional idea is to unify the grammar file and basically have one grammar for the whole solidity from 0.4 to date. This one, to me sounds the best tbh, if possible (and most probably is - did not research yet).
If we go with parser repo, then this is a cascading nightmare due to AST parser. Basically we would need to extend it to know which version it's talking about.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
There are different solidity versions we need to deal with. Potentially, we could go with let's say instead of solgo.parser into its own repository where we have parser.NewManager() and from which, with generics, we can load different types of parsers for different solidity versions.
Additional idea is to unify the grammar file and basically have one grammar for the whole solidity from 0.4 to date. This one, to me sounds the best tbh, if possible (and most probably is - did not research yet).
If we go with parser repo, then this is a cascading nightmare due to AST parser. Basically we would need to extend it to know which version it's talking about.
Not sure if we want to go this path -> a bit of music while reading this https://www.youtube.com/watch?v=6CwIB6pQoPo
Beta Was this translation helpful? Give feedback.
All reactions