Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can not disable release sync with --github false #196

Open
magicdawn opened this issue Jun 4, 2024 · 1 comment
Open

can not disable release sync with --github false #196

magicdawn opened this issue Jun 4, 2024 · 1 comment

Comments

@magicdawn
Copy link

magicdawn commented Jun 4, 2024

Environment

node v20.13.0

Reproduction

see below

Describe the bug

usage

  1. pnpm changelogen --clean --github false --release --minor
  2. git push --tags

with sync release, later tag push will report tag already exists
(and I need to test before push, so I don't want --push)

image

so I need to disable sync release. I found the code here
https://github.com/unjs/changelogen/blob/v0.5.5/src/commands/default.ts#L141

but this still not working because mri(argv) will treat --github=false / --github false as string, argv.github === 'false'

https://runkit.com/magicdawn/665f44d7aa755f00088dfac6
image


and -h / --help / help does not work, use a better cli lib please, clipanion or cac

Additional context

No response

Logs

No response

@magicdawn
Copy link
Author

and another issue --minor did not working, v0.0.2 became v0.0.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant