Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Walking and damage visual effects #70

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Walking and damage visual effects #70

merged 1 commit into from
Jul 2, 2024

Conversation

distortedfuzz
Copy link
Collaborator

(closes #58) (closes #60)

@distortedfuzz distortedfuzz self-assigned this Jun 29, 2024
umut-sahin
umut-sahin requested changes Jun 30, 2024
View reviewed changes
Copy link
Owner

@umut-sahin umut-sahin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a partial review, we'll go for round 2 once we resolve these comments.

game/src/core/depths.rs Outdated Show resolved Hide resolved
game/src/combat/plugin.rs Outdated Show resolved Hide resolved
game/src/combat/plugin.rs Outdated Show resolved Hide resolved
game/src/combat/plugin.rs Outdated Show resolved Hide resolved
game/src/lib.rs Outdated Show resolved Hide resolved
game/src/player/systems.rs Outdated Show resolved Hide resolved
game/src/player/systems.rs Outdated Show resolved Hide resolved
game/src/player/systems.rs Outdated Show resolved Hide resolved
game/src/player/systems.rs Outdated Show resolved Hide resolved
game/src/player/systems.rs Outdated Show resolved Hide resolved
umut-sahin
umut-sahin requested changes Jul 1, 2024
View reviewed changes
Copy link
Owner

@umut-sahin umut-sahin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, almost ready to be merged!

game/src/player/components.rs Outdated Show resolved Hide resolved
game/src/prelude.rs Outdated Show resolved Hide resolved
game/src/lib.rs Outdated Show resolved Hide resolved
game/src/effects/systems.rs Outdated Show resolved Hide resolved
game/src/effects/systems.rs Outdated Show resolved Hide resolved
game/src/effects/pop.rs Outdated Show resolved Hide resolved
game/src/effects/walking.rs Outdated Show resolved Hide resolved
game/src/combat/systems.rs Outdated Show resolved Hide resolved
game/src/combat/systems.rs Show resolved Hide resolved
game/src/combat/systems.rs Outdated Show resolved Hide resolved
umut-sahin
umut-sahin requested changes Jul 2, 2024
View reviewed changes
Copy link
Owner

@umut-sahin umut-sahin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably the last review, good job!

game/src/combat/systems.rs Outdated Show resolved Hide resolved
game/src/combat/systems.rs Outdated Show resolved Hide resolved
game/src/effect/walking.rs Outdated Show resolved Hide resolved
@distortedfuzz distortedfuzz force-pushed the walking-effect branch 2 times, most recently from c1209de to 811fee1 Compare July 2, 2024 14:40
@distortedfuzz distortedfuzz merged commit 81e757b into main Jul 2, 2024
5 checks passed
@distortedfuzz distortedfuzz deleted the walking-effect branch July 2, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umut-sahin umut-sahin umut-sahin approved these changes

Assignees

@distortedfuzz distortedfuzz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add visual effects to damage Add visual effects to walking
2 participants
@distortedfuzz @umut-sahin